Ignore client_max_window_bits with missing header #118
Conversation
|
The only error in the gh actions is I have tested it successfully both manually with a python client and within |
|
You can run I don't think this is the right fix what it's worth. This setting on the server indicates that the server doesn't want to accept windows larger than a certain size. I believe the correct behavior when that happens is to return |
When the client does not provide the "client_max_window_bits" option, the server must be able to handle a sliding window of up to 32,768 bytes. In case that the window has a lower limit set by options, compression must be disabled. Co-authored-by: Ignacio Martínez <[email protected]>
Kuroneer
force-pushed
the
client-less-window-bits-without-header
branch
from
5990041 to
a6fd4f1
Compare
|
(force pushed to remove the previous commit from the history and fix the message) |
|
@essen Is there anythin else you'd like to see changed? |
|
I just need to find the time to review and test. |
|
I will work on merging this now. I think I will change it to say |
|
OK nevermind about the |
|
Merged, thanks! |
When the client does not provide the "client_max_window_bits" option,
the server must reserve the max size.
Currently, if the server provides the option
client_max_window_bitswith something less than 15 and a client does not include the option and uses more than the unknown server value, zlib will fail to inflate the payload.I'll leave this in draft until I'm able to test it.
Are automatic tests for this functionality expected in
cowboy?